Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: [#508] FAQ Domain API μˆ˜μ •μ‚¬ν•­ 반영 #590

Merged
merged 3 commits into from
Jun 9, 2024
Merged

πŸ”€ :: [#508] FAQ Domain API μˆ˜μ •μ‚¬ν•­ 반영 #590

merged 3 commits into from
Jun 9, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented Jun 9, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

πŸ”€ :: [#508] FAQ Domain API μˆ˜μ •μ‚¬ν•­ 반영

Resolves: #508

πŸ“ƒ μž‘μ—…λ‚΄μš©

API μˆ˜μ •μ‚¬ν•­ 반영

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

οΏ½path λ§κ³ λŠ” λ³€κ²½λœκ²Œ λ”±νžˆ μ—†μŒ. > κ·ΈλŸ°μ€„ μ•Œμ•˜μœΌλ‚˜ ν•˜λ‚˜ 있음 description > answer
xcconfig μˆ˜μ •λ˜μ—ˆμŒ. (λ…Έμ…˜ μ—…λ‘œλ“œ μ™„λ£Œ)

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon merged commit df2342a into 491-LyricHighlighting Jun 9, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 508-domain-faq branch June 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824

@youn9k youn9k Awaiting requested review from youn9k

@baekteun baekteun Awaiting requested review from baekteun

Assignees

@KangTaeHoon KangTaeHoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KangTaeHoon @yongbeomkwak