Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing streams for large uploads to google storage via the GCS client #369

Merged

Conversation

k0p04ku
Copy link
Contributor

@k0p04ku k0p04ku commented Nov 9, 2022

Testing
image
image

I was able to successfully stream a video into GS.

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ k0p04ku
❌ kishan.patel


kishan.patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@cross311 cross311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change, just want to see testing more concrete that it works.

packages/gcp/src/__test__/GcsClient.test.ts Outdated Show resolved Hide resolved
@k0p04ku
Copy link
Contributor Author

k0p04ku commented Nov 11, 2022

I think this is a good change, just want to see testing more concrete that it works.

I've added an assertion regarding what exactly we're reading and writing into GS.

@k0p04ku k0p04ku requested a review from cross311 November 17, 2022 16:46
packages/gcp/src/index.ts Outdated Show resolved Hide resolved
@cross311 cross311 requested a review from plameniv November 18, 2022 14:59
@plameniv plameniv merged commit 632f75e into walmartlabs:develop Nov 18, 2022
@plameniv plameniv added enhancement New feature or request M-gcp This issue is related to the GCP module labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request M-gcp This issue is related to the GCP module
Development

Successfully merging this pull request may close these issues.

5 participants