Add API key to gRPC server and client #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plameniv
added
enhancement
YashGajera
reviewed
May 29, 2024
packages/grpc/src/internal/client.ts
Outdated
| @@ -86,7 +88,7 @@ export function createGrpcClient<T>( | |||
|
|
|||
| const metaCallback = (_params: any, callback: (arg0: null, arg1: Metadata) => void) => { | |||
| const meta = new Metadata(); | |||
| meta.add("custom-auth-header", "token"); | |||
| meta.add("custom-auth-header", apiKey || DEFAULT_API_KEY); | |||
There was a problem hiding this comment.
I think we can skip adding the header if there is no API Key provided. Also header name should be "authorization"
Suggested change
| meta.add("custom-auth-header", apiKey || DEFAULT_API_KEY); | |
| if(apiKey) { | |
| meta.add("authorization", apiKey); | |
| } |
There was a problem hiding this comment.
Added the if check a bit earlier
YashGajera
reviewed
May 29, 2024
packages/grpc/src/internal/client.ts
Outdated
Comment on lines
79
to
80
| certPath?: string, | ||
| apiKey?: string |
There was a problem hiding this comment.
May be we can turn this into object while this version is still in beta.
option?: {
Suggested change
| certPath?: string, | |
| apiKey?: string | |
| options?: { certPath?: string, | |
| apiKey?: string | |
| } |
There was a problem hiding this comment.
Created a separate interfaces for server and client
YashGajera
reviewed
May 29, 2024
YashGajera
reviewed
May 29, 2024
YashGajera
reviewed
May 29, 2024
YashGajera
approved these changes
May 29, 2024
cross311
reviewed
May 29, 2024
talam
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.