feat(api) Avoid using a closure to declare host function #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closures as host functions are going to be disabled for a moment in Wasmer, see wasmerio/wasmer#1841. In the `wasmer` Python package, we were passing a closure to `Function::new_with_env`. In order to get a regular function, this patch stores the previously captured varibles into the function environment. The only concerned variable is `result_types`.
Hywan
added
🎉 enhancement
Hywan
changed the title
jubianchi
approved these changes
Nov 27, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closures as host functions are going to be disabled for a moment in
Wasmer, see wasmerio/wasmer#1841. In the
wasmerPython package, we were passing a closure toFunction::new_with_env. In order to get a regular function, thispatch stores the previously captured varibles into the function
environment. The only concerned variable is
result_types.