Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASI without VM internals #3757

Merged
merged 10 commits into from
Apr 9, 2023
Merged

WASI without VM internals #3757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ccb5aa2
Move MemoryStyle creation after
syrusakbary Apr 8, 2023
8171ad1
Move vm memory up
syrusakbary Apr 8, 2023
014d113
Move VMMemory one level up (new thread)
syrusakbary Apr 8, 2023
214d416
Remove all references to VM store and sys
syrusakbary Apr 8, 2023
8be8885
Merge branch 'aarch64-stackprobe' into wasi-no-vm
syrusakbary Apr 8, 2023
6c4ea49
Move all vm internals out
syrusakbary Apr 8, 2023
19c1655
Fixed linting
syrusakbary Apr 8, 2023
a18c5eb
Merge branch 'master' into wasi-no-vm
syrusakbary Apr 9, 2023
83202ec
Simplified a bit the wasi-web crate by removing VMMemory
syrusakbary Apr 9, 2023
29b124e
Updated lock deps
syrusakbary Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions lib/api/src/externals/memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,21 @@ impl Memory {
}

/// Attempts to clone this memory (if its clonable) in a new store
pub fn clone_in_store(
&self,
store: &impl AsStoreRef,
new_store: &mut impl AsStoreMut,
) -> Option<Self> {
if !self.ty(store).shared {
// We should only be able to duplicate in a new store if the memory is shared
return None;
}
self.0
.try_clone(&store)
.map(|new_memory| Self::new_from_existing(new_store, new_memory))
}

/// Attempts to duplicate this memory (if its clonable) in a new store
pub fn duplicate_in_store(
&self,
store: &impl AsStoreRef,
Expand Down
Loading