Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflected Cross-site Scripting Vulnerability #199

Closed
JStefanikIBM opened this issue Sep 13, 2018 · 3 comments
Closed

Reflected Cross-site Scripting Vulnerability #199

JStefanikIBM opened this issue Sep 13, 2018 · 3 comments
Assignees

Comments

@JStefanikIBM
Copy link

JStefanikIBM commented Sep 13, 2018

The app appears to suffer from an XSS vulnerability.

Writing the following payload to the chat will result in an alertbox displaying the domain that is hosting the Node.js app.

<img src=x onerror=alert(document.domain)><!--`

The Javascript code of the page is doing a request to /api/message and it uses the input:text to write the content into the chatbox message after the request is done. This behaviour could allow an attacker to inject custom Javascript code that can be used to steal information from users or lure them to malicious websites.

@Oliver-I
Copy link
Contributor

@stevenpkg Can you look into this?

@stevenpkg
Copy link

stevenpkg commented Sep 13, 2018

@JStefanikIBM demo apps are meant to be simple applications using Watson services, and not necessarily commercial strength apps, @mitchmason @germanattanasio what do you all think?

@watson-github-bot
Copy link
Member

🎉 This issue has been resolved in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants