-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better tree shaking with @carbon/icons-react and carbon-react-components #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scovery-components into psulkava-improve_tree_shaking * 'improve_tree_shaking' of https://github.com/psulkava/discovery-components: fix: better tree shaking with @carbon/icons-react and carbon-react-components
jhpedemonte
requested review from
broulaye,
JohnWColby and
noah-eigenfeld
as code owners
September 3, 2021 14:52
JohnWColby
approved these changes
Sep 7, 2021
Build is failing during tests:
But when I run locally, it succeeds. Haven't been able to figure out why it's failing. |
…ee_shaking * origin/master: chore: publish v1.4.0-beta.7 [ci skip] fix: escape/unescape field name in search filters (#212) chore: publish v1.4.0-beta.6 [ci skip] fix: safari regex lookbehind (#211) chore: publish v1.4.0-beta.5 [ci skip] fix: escape field names before building aggregation string (#207)
Fixed with guidance from facebook/create-react-app#9938 (comment) |
This was referenced Sep 23, 2021
jhpedemonte
added a commit
that referenced
this pull request
Sep 23, 2021
* origin/master: chore: publish v1.4.0-beta.8 [ci skip] fix: better tree shaking with @carbon/icons-react and carbon-react-components (#209)
jhpedemonte
added a commit
that referenced
this pull request
Sep 23, 2021
…yarn/pdfjs-dist-2.9.359 * origin/master: chore(deps): bump debounce from 1.2.0 to 1.2.1 (#206) chore: publish v1.4.0-beta.8 [ci skip] fix: better tree shaking with @carbon/icons-react and carbon-react-components (#209) chore: publish v1.4.0-beta.7 [ci skip] fix: escape/unescape field name in search filters (#212) chore: publish v1.4.0-beta.6 [ci skip] fix: safari regex lookbehind (#211) chore: publish v1.4.0-beta.5 [ci skip] fix: escape field names before building aggregation string (#207) chore(deps-dev): bump audit-ci from 3.1.1 to 4.1.0 (#205) chore(deps-dev): bump eslint-plugin-import from 2.22.1 to 2.24.2 (#204) chore(deps-dev): bump @types/seedrandom from 2.4.28 to 3.0.1 (#197) chore(deps-dev): bump @rollup/plugin-alias from 3.1.1 to 3.1.5 (#201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do/fix?
Slightly updated version of #208.
Fixes #202
How do you test/verify these changes?
Compare building the example app with and without these changes:
Building from master:
Building with this PR:
Have you documented your changes (if necessary)?
Are there any breaking changes included in this pull request?