Checkstyle Fail build if checkstyle fails (#636)

* 🐛 fix checkstyle ignore failure * 🐛 test that checkstyle fails build * 🐛 test that checkstyle fails build * 🐛 checkstyle ignoreFailure false * 🐛 checkstyle block * 🐛 add more specific checkstyle blocks * 🐛 checkstyle added to travis * 🐛 checkstyle fix trailing space * 🐛 checkstyle fixes
watson-developer-cloud · Apr 4, 2017 · f0aac33 · f0aac33
1 parent 8357064
commit f0aac33
Show file tree

Hide file tree

Showing 23 changed files with 58 additions and 19 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -34,6 +34,8 @@ script:
   - ./gradlew test
   - ./gradlew codeCoverageReport
   - ./gradlew docs > /dev/null # build the javadoc
+  - ./gradlew checkstyleMain
+  - ./gradlew checkstyleTest
 
 after_success:
   - bash <(curl -s https://codecov.io/bash)

diff --git a/alchemy/build.gradle b/alchemy/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/build.gradle b/build.gradle
@@ -17,6 +17,19 @@ javadoc {
   source = 'src/main/java'
 }
 
+checkstyle {
+  ignoreFailures = false
+}
+
+checkstyleMain {
+  ignoreFailures = false
+}
+
+checkstyleTest {
+  ignoreFailures = false
+}
+
+
 task docs(type: Javadoc) {
   destinationDir = file("$buildDir/docs/all")
 }
@@ -45,8 +58,12 @@ allprojects {
 
 subprojects {
 
+  checkstyleMain {
+    ignoreFailures = false
+  }
+
   checkstyleTest {
-    ignoreFailures = true
+    ignoreFailures = false
   }
 
   afterEvaluate {

diff --git a/conversation/build.gradle b/conversation/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/core/build.gradle b/core/build.gradle
@@ -49,13 +49,10 @@ signArchives {
     }
 }
 
-checkstyleTest {
-    ignoreFailures = true
-}
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
   task testJar(type: Jar) {

diff --git a/core/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java b/core/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java
@@ -134,7 +134,7 @@ protected OkHttpClient configureHttpClient() {
         .build();
 
     builder.connectionSpecs(Arrays.asList(spec, ConnectionSpec.CLEARTEXT));
-    
+
     return builder.build();
   }
 

diff --git a/core/src/test/java/com/ibm/watson/developer_cloud/util/WaitFor.java b/core/src/test/java/com/ibm/watson/developer_cloud/util/WaitFor.java
@@ -21,7 +21,9 @@
 
 public class WaitFor {
 
-  private WaitFor() {}
+  private WaitFor() {
+
+  }
 
   /**
    * Static method used to wait for a specific condition to be satisfied.

diff --git a/dialog/build.gradle b/dialog/build.gradle
@@ -49,11 +49,9 @@ signArchives {
     }
 }
 
-checkstyleTest {
-    ignoreFailures = true
-}
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 task testJar(type: Jar) {

diff --git a/discovery/build.gradle b/discovery/build.gradle
@@ -50,12 +50,12 @@ signArchives {
 }
 
 checkstyleTest {
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/...overy/src/test/java/com/ibm/watson/developer_cloud/discovery/v1/DiscoveryServiceTest.java b/...overy/src/test/java/com/ibm/watson/developer_cloud/discovery/v1/DiscoveryServiceTest.java
@@ -73,7 +73,14 @@
 
 import static org.junit.Assert.assertEquals;
 
-import java.io.*;
+import java.io.FileReader;
+import java.io.FileNotFoundException;
+import java.io.InputStream;
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.BufferedWriter;
 import java.util.HashSet;
 import java.util.Set;
 

diff --git a/document-conversion/build.gradle b/document-conversion/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/java-sdk/build.gradle b/java-sdk/build.gradle
@@ -58,12 +58,12 @@ signArchives {
 }
 
 checkstyleTest {
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 task testJar(type: Jar) {

diff --git a/language-translation/build.gradle b/language-translation/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/language-translator/build.gradle b/language-translator/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/natural-language-classifier/build.gradle b/natural-language-classifier/build.gradle
@@ -50,12 +50,12 @@ signArchives {
 }
 
 checkstyleTest {
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/natural-language-understanding/build.gradle b/natural-language-understanding/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/personality-insights/build.gradle b/personality-insights/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/retrieve-and-rank/build.gradle b/retrieve-and-rank/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/speech-to-text/build.gradle b/speech-to-text/build.gradle
@@ -49,8 +49,13 @@ signArchives {
     }
 }
 
+checkstyleTest {
+    ignoreFailures = false
+}
+
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/text-to-speech/build.gradle b/text-to-speech/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/tone-analyzer/build.gradle b/tone-analyzer/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/tradeoff-analytics/build.gradle b/tradeoff-analytics/build.gradle
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {

diff --git a/visual-recognition/build.gradle b/visual-recognition/build.gradle
@@ -50,12 +50,12 @@ signArchives {
 }
 
 checkstyleTest {
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 dependencies {
-Original file line number
+Diff line change
@@ Expand Up / @@ -134,7 +134,7 @@ protected OkHttpClient configureHttpClient() { @@
             .build();
         builder.connectionSpecs(Arrays.asList(spec, ConnectionSpec.CLEARTEXT));
         return builder.build();
       }
@@ Expand Down @@