Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle Fail build if checkstyle fails #636

Merged
merged 10 commits into from
Apr 4, 2017
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ script:
- ./gradlew test
- ./gradlew codeCoverageReport
- ./gradlew docs > /dev/null # build the javadoc
- ./gradlew checkstyleMain
- ./gradlew checkstyleTest

after_success:
- bash <(curl -s https://codecov.io/bash)
Expand Down
1 change: 1 addition & 0 deletions alchemy/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
19 changes: 18 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@ javadoc {
source = 'src/main/java'
}

checkstyle {
ignoreFailures = false
}

checkstyleMain {
ignoreFailures = false
}

checkstyleTest {
ignoreFailures = false
}


task docs(type: Javadoc) {
destinationDir = file("$buildDir/docs/all")
}
Expand Down Expand Up @@ -45,8 +58,12 @@ allprojects {

subprojects {

checkstyleMain {
ignoreFailures = false
}

checkstyleTest {
ignoreFailures = true
ignoreFailures = false
}

afterEvaluate {
Expand Down
1 change: 1 addition & 0 deletions conversation/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
5 changes: 1 addition & 4 deletions core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,10 @@ signArchives {
}
}

checkstyleTest {
ignoreFailures = true
}

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = true
ignoreFailures = false
}

task testJar(type: Jar) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ protected OkHttpClient configureHttpClient() {
.build();

builder.connectionSpecs(Arrays.asList(spec, ConnectionSpec.CLEARTEXT));

return builder.build();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@

public class WaitFor {

private WaitFor() {}
private WaitFor() {

}

/**
* Static method used to wait for a specific condition to be satisfied.
Expand Down
4 changes: 1 addition & 3 deletions dialog/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ signArchives {
}
}

checkstyleTest {
ignoreFailures = true
}
checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

task testJar(type: Jar) {
Expand Down
4 changes: 2 additions & 2 deletions discovery/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ signArchives {
}

checkstyleTest {
ignoreFailures = true
ignoreFailures = false
}

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = true
ignoreFailures = false
}

dependencies {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,14 @@

import static org.junit.Assert.assertEquals;

import java.io.*;
import java.io.FileReader;
import java.io.FileNotFoundException;
import java.io.InputStream;
import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.io.BufferedWriter;
import java.util.HashSet;
import java.util.Set;

Expand Down
1 change: 1 addition & 0 deletions document-conversion/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
4 changes: 2 additions & 2 deletions java-sdk/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@ signArchives {
}

checkstyleTest {
ignoreFailures = true
ignoreFailures = false
}

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = true
ignoreFailures = false
}

task testJar(type: Jar) {
Expand Down
1 change: 1 addition & 0 deletions language-translation/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions language-translator/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
4 changes: 2 additions & 2 deletions natural-language-classifier/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ signArchives {
}

checkstyleTest {
ignoreFailures = true
ignoreFailures = false
}

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = true
ignoreFailures = false
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions natural-language-understanding/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions personality-insights/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions retrieve-and-rank/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
5 changes: 5 additions & 0 deletions speech-to-text/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,13 @@ signArchives {
}
}

checkstyleTest {
ignoreFailures = false
}

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions text-to-speech/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions tone-analyzer/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
1 change: 1 addition & 0 deletions tradeoff-analytics/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ signArchives {

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = false
}

dependencies {
Expand Down
4 changes: 2 additions & 2 deletions visual-recognition/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ signArchives {
}

checkstyleTest {
ignoreFailures = true
ignoreFailures = false
}

checkstyle {
configFile = rootProject.file('checkstyle.xml')
ignoreFailures = true
ignoreFailures = false
}

dependencies {
Expand Down