Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: adding new snippets #14

Merged
merged 2 commits into from
Dec 1, 2022
Merged

[FEAT]: adding new snippets #14

merged 2 commits into from
Dec 1, 2022

Conversation

YanDeLeon
Copy link
Collaborator

What is being done in this PR?

Addition of two new snippets for partials call and linkTo tags

What are the main choices made to get to this solution?

Two very handy snippets. Prefixes will be ppt for partials and plink for linkTo

List the manual test cases you've covered before sending this PR:

Example:
Try typing ppt and plink and make sure the snippets are working

@YanDeLeon YanDeLeon added the enhancement New feature or request label Dec 1, 2022
@YanDeLeon YanDeLeon requested a review from paganotoni December 1, 2022 14:54
@YanDeLeon YanDeLeon self-assigned this Dec 1, 2022
@paganotoni
Copy link
Member

@YanDeLeon lets update the README to include those 2 snippets.

Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanDeLeon we should add those in the README documentation.

@YanDeLeon YanDeLeon requested a review from paganotoni December 1, 2022 15:05
@paganotoni paganotoni merged commit 50d9677 into main Dec 1, 2022
@paganotoni paganotoni deleted the new-snippets branch December 1, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants