Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version lookup error #82

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Conversation

evpearson
Copy link
Collaborator

@evpearson evpearson commented Oct 20, 2021

Library documentation says that python versions should be provided like this:
python_versions = [
"cp36-cp36m"
"cp38-cp38"
]
This is, in fact, untrue. After 0.2.0, versions needed to be provided like
python_versions = [
"CP36_CP36M"
"CP38_CP38"
]

This PR makes fixes so that the provided documentation is accurate.

Testing:

  • I validated that little-cheesemonger 0.2.0 requires python versions be passed in with UPPER_SNAKE_CASE using Wheelhaus
  • Added unit tests verifying the different formats

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #82 (1f8d321) into main (6982d8a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          203       203           
  Branches        19        19           
=========================================
  Hits           203       203           
Impacted Files Coverage Δ
little_cheesemonger/__init__.py 100.00% <100.00%> (ø)
little_cheesemonger/_run.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@fhightower fhightower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this improvement.

@evpearson evpearson merged commit 2e31e51 into main Oct 21, 2021
@evpearson evpearson deleted the ep_fix_python_version_lookup_error branch October 21, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants