Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security updates #119

Merged
merged 7 commits into from
May 10, 2018
Merged

Security updates #119

merged 7 commits into from
May 10, 2018

Conversation

wayneashleyberry
Copy link
Owner

@wayneashleyberry wayneashleyberry commented May 10, 2018

  • Updates dependencies to fix security warnings.
  • Updates node versions on Travis
  • Removes Code Climate reporting, sadly the package is riddled with security issues

@wayneashleyberry wayneashleyberry self-assigned this May 10, 2018
@wayneashleyberry wayneashleyberry merged commit b67d48b into master May 10, 2018
@wayneashleyberry wayneashleyberry deleted the feature/update-dependencies branch May 10, 2018 18:17
@Thor77
Copy link
Collaborator

Thor77 commented May 11, 2018

Removes Code Climate reporting, sadly the package is riddled with security issues

Uh, I don't think that's a good reason to remove the badge + reporting.
I think we should try to fix those issues instead.

@wayneashleyberry
Copy link
Owner Author

@Thor77 the code climate reporter we were using has critical security issues and has been deprecated. It's nice to have, and we can look into integrating their new reporter.

But considering the following warnings, I thought it best to remove it as soon as possible.

[!] 8 vulnerabilities found [180 packages audited]
    Severity: 1 Low | 5 Moderate | 1 High | 1 Critical
    Run `npm audit` for more detail

@Thor77
Copy link
Collaborator

Thor77 commented May 12, 2018

Oh, you're absolutely right. I understood your message as

Removes Code Climate reporting, sadly the package [wunderline] is riddled with security issues

and therefore it seemed like a bad decision to me.
But yeah, integrating the new reporter is still a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants