Prevent self referential dir

* Found by fuzzer, prevent stack overflow of a self referential dir
wcampbell0x2a · Dec 1, 2024 · c5a7b5f · c5a7b5f
1 parent 97d5a08
commit c5a7b5f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/backhand/src/squashfs.rs b/backhand/src/squashfs.rs
@@ -533,6 +533,12 @@ impl<'b> Squashfs<'b> {
                         // BasicDirectory, ExtendedDirectory
                         InodeId::BasicDirectory | InodeId::ExtendedDirectory => {
                             // its a dir, extract all children inodes
+                            if *found_inode == dir_inode {
+                                error!("self referential dir to already read inode");
+                                return Err(BackhandError::UnexpectedInode(
+                                    dir_inode.inner.clone(),
+                                ));
+                            }
                             self.extract_dir(fullpath, root, found_inode, &self.id)?;
                             InnerNode::Dir(SquashfsDir::default())
                         }