Apply all other clippy fixes

backhand-test/tests/add.rs

@@ -1,6 +1,5 @@
 mod common;
 
-use std::process::Command;
 
 use assert_cmd::prelude::*;
 use tempfile::tempdir;
@@ -127,11 +126,11 @@ dr----x--t 2/4242                   42 1970-01-01 00:01 squashfs-root/test
 fn test_dont_emit_compression_options() {
     use std::fs::File;
     use std::io::Write;
-    use std::os::unix::prelude::PermissionsExt;
+
 
-    use backhand::DEFAULT_BLOCK_SIZE;
-    use nix::sys::stat::utimes;
-    use nix::sys::time::TimeVal;
+
+
+
 
     const FILE_NAME: &str = "out.squashfs";
     let asset_defs = [TestAssetDef {

backhand-test/tests/common/mod.rs

@@ -1,11 +1,7 @@
-use std::error::Error;
 use std::process::Command;
 use std::time::Duration;
 
 use assert_cmd::prelude::*;
-use backon::BlockingRetryable;
-use backon::ExponentialBuilder;
-use tempfile::tempdir;
 use tempfile::tempdir_in;
 use test_assets_ureq::TestAssetDef;
 

backhand-test/tests/mutate.rs

@@ -3,7 +3,6 @@ use std::fs::File;
 use std::io::{BufReader, BufWriter, Cursor};
 
 use backhand::{FilesystemReader, FilesystemWriter, NodeHeader};
-use common::{test_bin_unsquashfs, test_squashfs_tools_unsquashfs};
 use test_assets_ureq::TestAssetDef;
 use test_log::test;
 

backhand-test/tests/non_standard.rs

@@ -1,6 +1,6 @@
 mod common;
 use std::fs::File;
-use std::io::{BufReader, BufWriter, Write};
+use std::io::{BufReader, BufWriter};
 
 use backhand::compression::{CompressionAction, Compressor, DefaultCompressor};
 use backhand::kind::{self, Kind};
@@ -24,7 +24,7 @@ fn full_test(
     kind: &Kind,
     pad: Option<u32>,
 ) {
-    common::download_backoff(&assets_defs, test_path);
+    common::download_backoff(assets_defs, test_path);
     let og_path = format!("{test_path}/{filepath}");
     let new_path = format!("{test_path}/bytes.squashfs");
     {
@@ -33,7 +33,7 @@ fn full_test(
         let og_filesystem = FilesystemReader::from_reader_with_offset_and_kind(
             file,
             offset,
-            Kind::from_kind(&kind),
+            Kind::from_kind(kind),
         )
         .unwrap();
         let mut new_filesystem = FilesystemWriter::from_fs_reader(&og_filesystem).unwrap();
@@ -57,7 +57,7 @@ fn full_test(
         let _new_filesystem = FilesystemReader::from_reader_with_offset_and_kind(
             created_file,
             offset,
-            Kind::from_kind(&kind),
+            Kind::from_kind(kind),
         )
         .unwrap();
     }
@@ -140,7 +140,7 @@ fn test_custom_compressor() {
             if let Compressor::Gzip = compressor {
                 out.resize(out.capacity(), 0);
                 let mut decompressor = libdeflater::Decompressor::new();
-                let amt = decompressor.zlib_decompress(&bytes, out).unwrap();
+                let amt = decompressor.zlib_decompress(bytes, out).unwrap();
                 out.truncate(amt);
             } else {
                 unimplemented!();

backhand-test/tests/raw.rs

@@ -8,13 +8,12 @@ use backhand::{
     kind, CompressionExtra, ExtraXz, FilesystemCompressor, FilesystemWriter, NodeHeader,
     SuperBlock, DEFAULT_BLOCK_SIZE,
 };
-use common::{test_bin_unsquashfs, test_squashfs_tools_unsquashfs};
 use test_assets_ureq::TestAssetDef;
 
 #[test]
 #[cfg(all(feature = "xz", feature = "gzip"))]
 fn test_raw_00() {
-    use std::{io::BufReader, process::Command};
+    use std::io::BufReader;
 
     use backhand::{kind::Kind, FilesystemReader};
 

backhand-test/tests/replace.rs

@@ -1,6 +1,5 @@
 mod common;
 
-use std::process::Command;
 
 use assert_cmd::prelude::*;
 use tempfile::tempdir;

backhand-test/tests/test.rs

@@ -3,10 +3,8 @@ use std::fs::File;
 use std::io::{BufReader, BufWriter};
 
 use assert_cmd::prelude::*;
-use assert_cmd::Command;
 use backhand::{FilesystemReader, FilesystemWriter};
-use common::{test_bin_unsquashfs, test_squashfs_tools_unsquashfs};
-use tempfile::tempdir;
+use common::test_bin_unsquashfs;
 use test_assets_ureq::TestAssetDef;
 use test_log::test;
 use tracing::info;