Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support for the lib #634

Merged
merged 17 commits into from
Nov 12, 2024

Conversation

Wolfyxon
Copy link
Contributor

@Wolfyxon Wolfyxon commented Nov 10, 2024

I'm working on a tool that natively builds AppImages without appimagetool and I also need it to work under Windows.
This allows backhand to compile and work under Windows by not relying on unix specific modules.

@Wolfyxon Wolfyxon changed the title Add Windows support Add Windows support for the lib Nov 10, 2024
@Wolfyxon Wolfyxon marked this pull request as ready for review November 10, 2024 20:35
@Wolfyxon
Copy link
Contributor Author

Wolfyxon commented Nov 10, 2024

I tested everything on both Windows and Linux.
Files are read and pushed without any issues.

Images made on Windows are handled properly on Linux and vice-versa.

@wcampbell0x2a
Copy link
Owner

Thanks! I'll make sure to check this out.

@wcampbell0x2a
Copy link
Owner

@Wolfyxon please run cargo fmt

@Wolfyxon
Copy link
Contributor Author

Done

@wcampbell0x2a
Copy link
Owner

Thanks!

@wcampbell0x2a wcampbell0x2a merged commit c961a0c into wcampbell0x2a:master Nov 12, 2024
34 of 36 checks passed
@Wolfyxon Wolfyxon deleted the windows-support branch November 12, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants