Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendship Ended With Dependabot #660

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

wcampbell0x2a
Copy link
Owner

Two things have driven me away from dependabot, and I don't think there is
any movement with fixing these issues. Maybe renovate fixes these issues but
I have yet to try it out!

  • Dependabot will bump the Cargo.toml version of a dependacy, but it never needs to
    unless a non-patch version was updated! This limits the libraries a user could
    use downstream, for no reason. All that needs to happen is that the Cargo.lock changes
    so I can verify my library with a set of libraries that could end up in the users
    stream.
  • Dependabot never will update recursive depends, Ever! This is a huge problem for my
    own testing and benchmarks, as unless I rememeber that dependabot does this I will never
    update build-dependencies of downstream projects, such as cc! This leads to wildly different
    testing of downstream projects, since they will use the most up-to-date.

Two things have driven me away from dependabot, and I don't think there is
any movement with fixing these issues. Maybe renovate fixes these issues but
I have yet to try it out!

* Dependabot will bump the Cargo.toml version of a dependacy, but it never needs to
  unless a non-patch version was updated! This limits the libraries a user _could_
  use downstream, for no reason. All that needs to happen is that the Cargo.lock changes
  so I can verify my library with a _set_ of libraries that _could_ end up in the users
  stream.
* Dependabot *never* will update recursive depends, Ever! This is a huge problem for my
  own testing and benchmarks, as unless I rememeber that dependabot does this I will never
  update build-dependencies of downstream projects, such as cc! This leads to wildly different
  testing of downstream projects, since they will use the most up-to-date.
@github-actions github-actions bot added the A-CI GitHub Action label Jan 4, 2025
@wcampbell0x2a wcampbell0x2a changed the title Fix docs.rs failed build Friendship Ended With Dependabot Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Benchmark for 36f7cfd

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.5±0.00ms 2.5±0.00ms 0.00%
only_read/tplink_ax1800 6.6±0.04ms 6.6±0.00ms 0.00%
unsquashfs/full 10.5±0.10ms 10.5±0.12ms 0.00%
unsquashfs/full-path-filter 7.2±0.22ms 7.3±0.16ms +1.39%
unsquashfs/list 7.3±0.06ms 7.3±0.19ms 0.00%
unsquashfs/list-path-filter 6.5±0.03ms 6.5±0.06ms 0.00%
write_read/netgear_ax6100v2 1416.5±1.98ms 1421.8±2.78ms +0.37%
write_read/tplink_ax1800 8.0±0.01s 8.0±0.02s 0.00%

@wcampbell0x2a wcampbell0x2a merged commit 1073b4b into master Jan 4, 2025
54 checks passed
@wcampbell0x2a wcampbell0x2a deleted the friendship-ended-with-dependabot branch January 4, 2025 18:34
@wcampbell0x2a wcampbell0x2a mentioned this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI GitHub Action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant