Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Release process should only update DockerHub latest images when releasing from master #1383

Closed
awh opened this issue Sep 3, 2015 · 6 comments
Closed

Release process should only update DockerHub latest images when releasing from master #1383

awh opened this issue Sep 3, 2015 · 6 comments
Assignees
@awh
Labels
chore
Milestone
1.1.0

Comments

@awh
Copy link
Contributor

awh commented Sep 3, 2015

No description provided.

@awh awh added the chore label Sep 3, 2015
@awh awh self-assigned this Sep 4, 2015
@awh
Copy link
Contributor Author

awh commented Sep 4, 2015

@rade how do you feel about bin/release publish switching its 'latest' update behaviour based on detecting an vX.Y.Z version string where Z != 0?

@rade
Copy link
Member

rade commented Sep 4, 2015

Fine by me. But I haven't given this much thought. @squaremo?

@awh
Copy link
Contributor Author

awh commented Sep 4, 2015

In that case... does it make sense to drive the --pre-release behaviour from the same inference, and remove that flag too?

@rade
Copy link
Member

rade commented Sep 4, 2015

maybe :)

@awh
Copy link
Contributor Author

awh commented Sep 4, 2015

It is a bit prescriptive, but it removes opportunities for human error...

@rade
Copy link
Member

rade commented Sep 4, 2015

it removes opportunities for human error...

That's a good thing indeed. Less to think about and get wrong.

@awh awh mentioned this issue Sep 4, 2015
Merged
@rade rade closed this as completed in #1387 Sep 7, 2015
rade added a commit that referenced this issue Sep 7, 2015
@rade
Merge pull request #1387 from /issues/1383-switch-release-behaviour-o…
d79ac3c 
…n-type

Only update DockerHub `latest` images on mainline release

Fixes #1383.
@rade rade added this to the 1.1.0 milestone Sep 7, 2015
@awh awh mentioned this issue Sep 9, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@awh awh

Labels
chore
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@rade @awh