Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fix dotted imports for logging #1254

Merged
merged 3 commits into from
Aug 3, 2015
Merged

Fix dotted imports for logging #1254

merged 3 commits into from
Aug 3, 2015

Conversation

dpw
Copy link
Contributor

@dpw dpw commented Aug 3, 2015

Many router files do a dotted import of common for the sake of Log. This means everything else from common ends up in scope, for the sake of a single variable.

@squaremo squaremo merged commit e7ee728 into weaveworks:master Aug 3, 2015
@squaremo
Copy link
Contributor

squaremo commented Aug 3, 2015

NB tested by pushing to a branch in this repo: https://circleci.com/gh/weaveworks/weave/2244

@rade rade modified the milestone: 1.1.0 Aug 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dpw @squaremo @rade