This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Make address argument to weave dns-{add|remove} optional
#1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't swallow errors in the docker client.
…aces in subsequent tests.
Correctly stop the test gossip router to prevent complaints of data races in subsequent tests.
since $CONTAINER gets stomped on by various functions, in particular populate_dns. Broken by weaveworks#1065.
using the same "always shift one" approach as in proxy_args
and ditch the wait_for_status, since we've only just called that
undocumented, since it is mainly meant for testing
Thus unbreaking it post weaveworks#1065.
…tiweave Disable dns in multiweave
…) for debugging. Also, make Address marshall into json as an IP string, not a number.
Don't periodically delete all non-tombstone entries. Fixes weaveworks#1177.
1) We cannot send "Connection: close", because the fsouza docker client expects the tcp socket to stay open between requests. 2) Because we cannot force-close the connection, we can't hijack the connection (because go's net/http doesn't let use un-hijack it). 3) Because we need to maintain the individual chunking of messages (for docker-py), we can't just copy the response body, as Go will remove and re-add the chunking willy-nilly. Therefore, we have to read each chunk one-by-one, and flush the ResponseWriter after each one.
…up of pending messages.
('docker kill' breaks restart policy)
… container entrypoint. We have moved the 'route add' command to the end of 'attach', so this indicates that all network interface set-up is complete.
This was missed in weaveworks#1327.
…-adverse-firewall-config Warn on detection of REJECT rule in FORWARD chain Fixes weaveworks#1266.
…tlink Wait for ethwe via netlink, not via polling or signals Fixes weaveworks#1209. Fixes weaveworks#1258. Fixes weaveworks#1300.
Conflicts: proxy/create_exec_interceptor.go test/600_proxy_docker_py_test.sh
Fix docker api proxy smoke-tests after docker-py change
…ewrite-hosts LGTM. Fixes weaveworks#1373
| $ C=$(docker run -e WEAVE_CIDR=10.2.1.27/24 -ti ubuntu) | ||
| $ weave dns-add 10.2.1.27 $C -h pingme2.weave.local | ||
| $ C=$(docker run -ti ubuntu) | ||
| $ weave dns-add $C -h pingme2.weave.local |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Conflicts: site/weavedns.md
awh
force-pushed
the
issues/1369-weave-dns-add-remove-optional-ip
branch
from
f6fe1b9 to
0125e67
Compare
|
For some reason GitHub thinks there are 563 commits in this PR - I'm going to close it and create a new one to be on the safe side... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1369.