Use Testcontainers Weaviate module #263
Conversation
src/test/java/io/weaviate/integration/client/WeaviateWithOidcContainer.java
Outdated
Show resolved
Hide resolved
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
|
I agree |
| public static DockerComposeContainer compose = new DockerComposeContainer( | ||
| new File("src/test/resources/docker-compose-azure.yaml") | ||
| ).withExposedService("weaviate-auth-azure_1", 8081, Wait.forHttp("/v1/.well-known/openid-configuration").forStatusCode(200)); | ||
| public static WeaviateContainer weaviate = new WeaviateWithAzureContainer("semitechnologies/weaviate:1.23.1"); |
There was a problem hiding this comment.
would be great to set Weaviate docker version in one place. We use EXPECTED_WEAVIATE_VERSION to check a current version, we can use this to pass a docker image:
String.format("semitechnologies/weaviate:%s", EXPECTED_WEAVIATE_VERSION)
There was a problem hiding this comment.
I would change this in all containers
|
@eddumelendez great PR! Could you rebase your PR against our lastest |
Testcontainers 1.19.6 provides a `weaviate` module.
eddumelendez
force-pushed
the
testcontainers
branch
from
0ce897a
to
fa4350f
Compare
|
@antas-marcin changes have been applied. |
|
@eddumelendez thank you for such a quick response! Your changes look great! Once the tests are green I will merge your PR. Thank you for you contribution! |
Testcontainers 1.19.6 provides a
weaviatemodule.