-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #74: Include model_path in /meta endpoint response #100
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Infrastructure as Code | 0 1 4 0 | View in Orca |
Passed | SAST | 0 20 0 0 | View in Orca |
Passed | Secrets | 0 0 0 0 | View in Orca |
Passed | Vulnerabilities | 0 0 0 0 | View in Orca |
🛡️ The following IaC misconfigurations have been detected
NAME | FILE | ||
---|---|---|---|
Missing User Instruction | Dockerfile | View in code | |
Healthcheck Instruction Missing | Dockerfile | View in code | |
Pip install Keeping Cached Packages | Dockerfile | View in code | |
Pip install Keeping Cached Packages | Dockerfile | View in code | |
Unpinned Package Version in Pip Install | Dockerfile | View in code |
🛡️ The following SAST misconfigurations have been detected
NAME | FILE | ||
---|---|---|---|
Container Command Detected with Extended Privileges | ..._push_custom_base.sh | View in code | |
Container Command Detected with Extended Privileges | cicd/docker_push.sh | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_auth_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_test.py | View in code | |
Missing timeout in requests module can cause DoS | smoke_test.py | View in code | |
Missing timeout in requests module can cause DoS | test_app.py | View in code | |
Missing timeout in requests module can cause DoS | test_app.py | View in code | |
Missing timeout in requests module can cause DoS | test_app.py | View in code | |
Security Risks of Using the Subprocess Module | test_app.py | View in code |
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
I agree to the Contributor License Agreement (CLA). |
I updated the Meta.get() method in meta.py to include the model_path in the response. This makes it easy to find where the model is stored, especially in setups where file paths might be unclear.
The model_name was already included in the response, so I did not add it again. Adding only the model_path keeps the response clear and avoids repeating the same information.
@CaseyHaralson, I hope this addresses your request.