Fix T5 model embedding generation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antas-marcin
force-pushed
the
fix-t5-model-embedding-generation
branch
2 times, most recently
from
5e7b912 to
ddbb393
Compare
tsmith023
approved these changes
Oct 26, 2023
antas-marcin
force-pushed
the
fix-t5-model-embedding-generation
branch
from
ddbb393 to
fb9d535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
SentenceTransformerlibrary for embeddings generation.This PR also fixes a bug which resulted in T5 models generating embeddings with different dimensions then actually this model was able to generate. This bug was fixed by introducing
SentenceTransformerlibrary for embeddings generation instead of the original implementation.