-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockMax WAND #6176
Merged
Merged
BlockMax WAND #6176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored code and added tests to improve the bitpacked entry and data encoding
…n they are small When the posting lists are < 4-6 docs, it may be worth it to write them non-compressed due to the compression overhead
Works but it is not very efficient
…ed package interactions
…mbination Make BlockMax search work for multiple segments and properties by combining the results
… variable naming for clarity
…Wand to Pivot for consistency
…tency and clarity in bucket operations
…proved readability and maintainability
…o loadAllTombstones method for improved clarity
…ilter for improved clarity and consistency in handling tombstones and filters
…encoding and decoding for better readability
… varint encoding and decoding for better readability" This reverts commit c6c0041.
The duplication here mostly comes from tests:
|
amourao
requested review from
parkerduckworth
and removed request for
parkerduckworth
December 3, 2024 17:29
…com:weaviate/weaviate into poc-blockmax-wand
…breaks other tests
Quality Gate failedFailed conditions |
parkerduckworth
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
Review checklist
Cross-functional impact