Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimise website building and fix incorrect links. #762

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

rqzheng2015
Copy link
Contributor

@rqzheng2015 rqzheng2015 commented Mar 21, 2022

PR Details

feat: optimise website building and incorrect links.

Description

This PR contains these changes above:

  1. upgrade Docusaurus to 2.0.0-beta.16
  2. fix broken link due to Docusaurus upgrade,feat(content-docs): sidebar category linking to document or auto-generated index page facebook/docusaurus#5830
  3. remove nodejieba dependency and related build steps, as @easyops-cn/docusaurus-search-local has replaced nodejieba with @node-rs/jieba
  4. fix sharp building issue by locking sharp and minipass dependencies versions

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated changeset
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cla-bot cla-bot bot added the cla-signed label Mar 21, 2022
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2022

⚠️ No Changeset found

Latest commit: 96a716f729f14cabc20ec8d4a82ad0851b91283c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rqzheng2015 rqzheng2015 changed the title feat: optimise website building and incorrect links. feat: optimise website building and fix incorrect links. Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #762 (e44494f) into main (bf35b60) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         813      813           
  Lines       34889    34889           
  Branches     6526     6526           
=======================================
  Hits        20234    20234           
  Misses      14616    14616           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf35b60...e44494f. Read the comment docs.

@rqzheng2015 rqzheng2015 enabled auto-merge (squash) March 21, 2022 07:24
@rqzheng2015 rqzheng2015 force-pushed the fix/fix_website_0321 branch from 96a716f to e44494f Compare March 21, 2022 07:42
@rqzheng2015 rqzheng2015 merged commit 03647cb into web-infra-dev:main Mar 21, 2022
targeral pushed a commit that referenced this pull request Jun 10, 2022
targeral pushed a commit that referenced this pull request Jun 10, 2022
targeral pushed a commit that referenced this pull request Jun 10, 2022
targeral pushed a commit that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants