Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let lightningcss minimizer inherit loader options #4392

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 18, 2025

Summary

If user has configured tools.lightningcssLoader options, we should will use them as the default CSS minimizer options.

This helps to keep development and production consistent.

Related Links

resolve #4374

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit a352678
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/678bb8f45c2fe000081b093a
😎 Deploy Preview https://deploy-preview-4392--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit b9b4cfb into main Jan 19, 2025
9 checks passed
@chenjiahan chenjiahan deleted the lightningcss_inherit_0118 branch January 19, 2025 00:28
@chenjiahan chenjiahan mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tools.lightningcssLoader.exclude not work in building
1 participant