fix: ci

web-infra-dev · Dec 13, 2024 · e4322c9 · e4322c9
1 parent df4ed65
commit e4322c9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/crates/rspack_binding_options/src/options/raw_experiments/raw_cache/raw_storage.rs b/crates/rspack_binding_options/src/options/raw_experiments/raw_cache/raw_storage.rs
@@ -15,7 +15,7 @@ impl From<RawStorageOptions> for StorageOptions {
       "filesystem" => StorageOptions::FileSystem {
         directory: value.directory.into(),
       },
-      s => panic!("unsupport storage type {s}"),
+      s => panic!("unsupported storage type {s}"),
     }
   }
 }
diff --git a/packages/rspack/src/config/defaults.ts b/packages/rspack/src/config/defaults.ts
@@ -88,7 +88,14 @@ export const applyRspackOptionsDefaults = (
 	// but Rspack currently does not support this option
 	F(options, "cache", () => development);
 
-	applyExperimentsDefaults(options.experiments, { production });
+	applyExperimentsDefaults(options.experiments, {
+		production,
+		disableCache: options.cache === false
+	});
+
+	if (options.experiments.cache === false) {
+		options.cache = false;
+	}
 
 	applySnapshotDefaults(options.snapshot, { production });
 
@@ -194,10 +201,13 @@ const applyInfrastructureLoggingDefaults = (
 
 const applyExperimentsDefaults = (
 	experiments: ExperimentsNormalized,
-	{ production }: { production: boolean }
+	{ production, disableCache }: { production: boolean; disableCache: boolean }
 ) => {
 	// IGNORE(experiments.cache): In webpack, cache is undefined by default
 	F(experiments, "cache", () => !production);
+	if (disableCache) {
+		experiments.cache = false;
+	}
 
 	D(experiments, "futureDefaults", false);
 	// IGNORE(experiments.lazyCompilation): In webpack, lazyCompilation is undefined by default