Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix banner link #6401

Merged
merged 1 commit into from
Apr 29, 2024
Merged

docs: fix banner link #6401

merged 1 commit into from
Apr 29, 2024

Conversation

Sunny-117
Copy link
Contributor

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 986721a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/662f659379bee90008ac97fa
😎 Deploy Preview https://deploy-preview-6401--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sunny-117 Sunny-117 mentioned this pull request Apr 29, 2024
Closed
2 tasks
@chenjiahan
Copy link
Member

Thanks!

@chenjiahan chenjiahan enabled auto-merge (squash) April 29, 2024 14:06
@chenjiahan chenjiahan merged commit af80a3f into web-infra-dev:main Apr 29, 2024
34 checks passed
@chenjiahan
Copy link
Member

@Timeless0911 Rspress should apply i18n for banner links in this case

@Timeless0911
Copy link
Contributor

@Timeless0911 Rspress should apply i18n for banner links in this case

web-infra-dev/rspress#924 already have issue tracking it.

@chenjiahan
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sunny-117 @chenjiahan @Timeless0911