Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: unify the logic of span_to_location into trait SourcePosition #8640

Merged
merged 1 commit into from
Dec 16, 2024
Merged

refactor: unify the logic of span_to_location into trait SourcePosition #8640

merged 1 commit into from
Dec 16, 2024

Conversation

shulaoda
Copy link
Collaborator

@shulaoda shulaoda commented Dec 7, 2024

Summary

I have unified this logic into dependency_location.rs.

rspack/crates/rspack_plugin_javascript/src/parser_and_generator/mod.rs

Lines 379 to 380 in 8646ecf

// Todo(shulaoda): check if this can be removed
fn span_to_location(span: Span, source: &str) -> Option<String> {

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda requested a review from h-a-n-a December 7, 2024 07:16
@netlify Netlify
Copy link

netlify bot commented Dec 7, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ca53fa
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6754081044661900088620d4

@shulaoda shulaoda marked this pull request as draft December 7, 2024 07:45
@shulaoda shulaoda force-pushed the refactor/remove-unnecessary-location-transform branch from 11f668d to 7a1ea2e Compare December 7, 2024 07:45
@shulaoda shulaoda changed the title refactor: remove unnecessary function span_to_location refactor: unify the logic of span_to_location into trait SourcePosition Dec 7, 2024
@shulaoda shulaoda force-pushed the refactor/remove-unnecessary-location-transform branch from 7a1ea2e to 04f82d8 Compare December 7, 2024 07:51
@shulaoda shulaoda force-pushed the refactor/remove-unnecessary-location-transform branch from 04f82d8 to 9ca53fa Compare December 7, 2024 08:32
@shulaoda shulaoda marked this pull request as ready for review December 7, 2024 09:12
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Dec 12, 2024

I've been a little bit busy lately. Thanks for waiting. I will take a look tomorrow.

@h-a-n-a h-a-n-a enabled auto-merge (squash) December 16, 2024 06:14
@h-a-n-a h-a-n-a merged commit 1f65a35 into web-infra-dev:main Dec 16, 2024
33 checks passed
@shulaoda shulaoda deleted the refactor/remove-unnecessary-location-transform branch December 16, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulaoda @h-a-n-a