Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify support for JavaScriptModulesPlugin as partial #8678

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

steverep
Copy link
Contributor

Summary

Currently the plugin support table claims full support for JavascriptModulesPlugin, but that's not correct. The static getCompilationHooks method only returns the chunkHash hook, but there are quite a few more.

For example, my plugin transform-async-modules-webpack-plugin cannot be rspack compatible because it uses the renderModuleContent tap. Here's the full list of hooks:

https://github.com/webpack/webpack/blob/8a04c64e5e8e1b7ed1fd4b942a3d277296f14ef9/lib/javascript/JavascriptModulesPlugin.js#L175-L190

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b7966f7
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/675a5e3d51afd00008e232dd
😎 Deploy Preview https://deploy-preview-8678--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steverep steverep changed the title Clarify support for JavaScriptModulesPlugin as partial docs: clarify support for JavaScriptModulesPlugin as partial Dec 12, 2024
@github-actions github-actions bot added the release: document release: document related release(mr only) label Dec 12, 2024
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this information!

If you’d like Rspack to support more hooks in JavascriptModulesPlugin , feel free to file an issue. ❤️

@chenjiahan chenjiahan merged commit 9b6d2a5 into web-infra-dev:main Dec 12, 2024
37 of 38 checks passed
@steverep steverep deleted the patch-1 branch December 12, 2024 13:34
@steverep
Copy link
Contributor Author

Thanks... opened #8714 to track support for more hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: document release: document related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants