Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mf parse range not compat with safari #8749

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: mf parse range not compat with safari #8749

merged 1 commit into from
Dec 17, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Dec 17, 2024

Summary

fix #8704

Avoid zero-width assertion regex for older version safari

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from chenjiahan December 17, 2024 13:06
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 17, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 17, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 9e5b053
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67617754b5895600082bcb2d

chenjiahan
chenjiahan approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 75f0d20 into main Dec 17, 2024
37 checks passed
@chenjiahan chenjiahan deleted the fix-mf-safari branch December 17, 2024 13:52
@chenjiahan chenjiahan mentioned this pull request Dec 17, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

@ahabhgk ahabhgk

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @chenjiahan