refactor: remove as much getRawOptions as possible
#8773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #8773 will not alter performanceComparing Summary
|
h-a-n-a
force-pushed
the
remove-get-raw-options
branch
from
1cb822f to
005b5a1
Compare
ahabhgk
approved these changes
Dec 19, 2024
LingyuCoder
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RawOptionsis a intermediate representation for normalized rspack options. This is used to normalize optionsfrom JS to better fit to rust data structures. In this PR, as much
getRawOptionslogic is moved to the rust side.Checklist