Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new optimization.avoidEntryIife config #8814

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Dec 23, 2024

Summary

Sync webpack/webpack#18772 from webpack.

Currently, the default value of optimization.avoidEntryIife in webpack is set to true when "mode" is set to "production". I'll try to change the default value of webpack, as in practice, performance impact caused by this IIFE is minimal, but it requires a significant amount of build performance.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 7eb7693
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676a77b3c1a20c0008dbca38
😎 Deploy Preview https://deploy-preview-8814--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #8814 will not alter performance

Comparing fi3ework:avoidIifeEntry (7eb7693) with main (d87bd86)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@fi3ework fi3ework force-pushed the avoidIifeEntry branch 3 times, most recently from df762a6 to 00ab82a Compare December 23, 2024 12:09
@fi3ework
Copy link
Member Author

Seem the CI failed due to hitting an obsolete cache, do you know how to clean the cache of GitHub CI @SyMind 🤔?

    -   !*** css ../../../../../node_modules/.pnpm/[email protected]_@rspack+core@[email protected]_@[email protected]_@swc+helpers@0_iv7sxheyzzaaxpd4oeahvl3r34/node_modules/css-loader/dist/cjs.js!./other.css ***!
    +   !*** css ../../../../../node_modules/.pnpm/[email protected]_@rspack+core@[email protected]_@[email protected]_@swc+helpers@0_aku7xtrc3x5l3vpfenkieaz5om/node_modules/css-loader/dist/cjs.js!./other.css ***!
        \**********************************************************************************************************************************************************************************************************************/

@fi3ework fi3ework force-pushed the avoidIifeEntry branch 3 times, most recently from 6137fb4 to 7808033 Compare December 24, 2024 07:16
@fi3ework fi3ework marked this pull request as ready for review December 24, 2024 11:21
@fi3ework fi3ework requested a review from ahabhgk December 24, 2024 11:22
@ahabhgk ahabhgk merged commit 27dca00 into web-infra-dev:main Dec 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants