Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cgm hash to verify rename inline modules cache #8820

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Dec 23, 2024

Summary

Use ChunkGraph module hash to verify the rename_module_cache, build_info().hash represents the module's originalSource, but it's possible to generate different result with the same originalSource (checkout added test).

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4410482
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676a425733f4cf0007a15890

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #8820 will not alter performance

Comparing ahabhgk:fix-rename-inline (4410482) with main (4da33a8)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@ahabhgk ahabhgk enabled auto-merge (squash) December 24, 2024 04:54
@ahabhgk ahabhgk requested review from fi3ework and JSerFeng December 24, 2024 04:54
@ahabhgk ahabhgk requested a review from fi3ework December 24, 2024 05:10
@ahabhgk ahabhgk merged commit c99e882 into web-infra-dev:main Dec 24, 2024
32 checks passed
@ahabhgk ahabhgk deleted the fix-rename-inline branch December 24, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants