Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(incremental): better parallel for side effects plugin rebuild #8848

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Dec 25, 2024

Summary

follow up #8799

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 25, 2024
Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 3a7ec5b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676bdb7f7dae0c0008d32b3f
😎 Deploy Preview https://deploy-preview-8848--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #8848 will not alter performance

Comparing inc-perf-side-effects (3a7ec5b) with main (93fc6ab)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@ahabhgk ahabhgk enabled auto-merge (squash) December 25, 2024 10:17
@ahabhgk ahabhgk requested a review from JSerFeng December 25, 2024 10:17
@ahabhgk ahabhgk merged commit 21af7d9 into main Dec 25, 2024
32 checks passed
@ahabhgk ahabhgk deleted the inc-perf-side-effects branch December 25, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants