Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cli): lazy import rechoir and interpret #8856

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

rechoir and interpret are only used when loading rspack.config.ts or rspack.config.mts.

Lazy importing them can make Rspack CLI 20ms faster in most cases.

Screenshot 2024-12-26 at 17 49 04

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Dec 26, 2024
Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7a6f7a4
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676d28d3c4bd7600086c8b8a

Copy link

codspeed-hq bot commented Dec 26, 2024

CodSpeed Performance Report

Merging #8856 will not alter performance

Comparing cli_lazy_import_1226 (7a6f7a4) with main (7707956)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@chenjiahan chenjiahan enabled auto-merge (squash) December 26, 2024 10:19
@chenjiahan chenjiahan merged commit c73c7e1 into main Dec 26, 2024
36 checks passed
@chenjiahan chenjiahan deleted the cli_lazy_import_1226 branch December 26, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants