Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should recognize negative preload value #8862

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

JSerFeng
Copy link
Contributor

Summary

webpackPreload and webpackPrefetch magic comments can set preload and prefetch to script tag, the value of these comments determine the priority and the order of preloaded chunks. The value can also be negative, as it is only for ordering.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Dec 27, 2024
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a384f50
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676e7947f1944000087e7de2

@JSerFeng JSerFeng force-pushed the fix/preload-prefetch branch from 74bc1b9 to 662d379 Compare December 27, 2024 08:45
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #8862 will not alter performance

Comparing fix/preload-prefetch (a384f50) with main (6f12327)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@JSerFeng JSerFeng force-pushed the fix/preload-prefetch branch from 662d379 to a384f50 Compare December 27, 2024 09:54
@JSerFeng JSerFeng requested a review from LingyuCoder December 27, 2024 15:08
@LingyuCoder LingyuCoder enabled auto-merge (squash) December 27, 2024 15:30
@LingyuCoder LingyuCoder merged commit 6891072 into main Dec 27, 2024
32 checks passed
@LingyuCoder LingyuCoder deleted the fix/preload-prefetch branch December 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants