fix: rspack_version macro support match alpha version #8880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team
✅ Deploy Preview for rspack canceled.
|
LingyuCoder
approved these changes
Dec 30, 2024
CodSpeed Performance ReportMerging #8880 will not alter performanceComparing Summary
|
hardfist
approved these changes
Dec 30, 2024
| @@ -1,5 +1,5 @@ | |||
| pub fn rspack_version() -> String { | |||
| let re = regex::Regex::new(r#""version": ?"([0-9\.]+)""#).expect("should create regex"); | |||
| let re = regex::Regex::new(r#""version": ?"([0-9a-zA-Z\.-]+)""#).expect("should create regex"); | |||
There was a problem hiding this comment.
this is kind of too hacky, even formatter will kill this
There was a problem hiding this comment.
why not using json parse?
There was a problem hiding this comment.
Our package.json is in a standard json format, so there should be no problem in theory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rspack_version!()macro support match alpha version like1.2.0-alpha.0Checklist