Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: source-map-devtool-plugin file context option #8888

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: source-map-devtool-plugin file context option #8888

merged 1 commit into from
Dec 30, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 30, 2024 •
edited
Loading

Summary

Fix #8881

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 30, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 4542432
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/677265d2e72e3e00087f8d6d
😎 Deploy Preview https://deploy-preview-8888--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SyMind SyMind marked this pull request as ready for review December 30, 2024 09:20
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #8888 will not alter performance

Comparing fix-source-map-devtool-plugin (4542432) with main (92e5e4f)

Summary

✅ 3 untouched benchmarks

@SyMind SyMind merged commit aeb444f into main Dec 30, 2024
40 checks passed
@SyMind SyMind deleted the fix-source-map-devtool-plugin branch December 30, 2024 10:46
JSerFeng
JSerFeng reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@JSerFeng JSerFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone comes here to see what's changed and why, here the filename parameter variable is shadowed before ...

@h-a-n-a h-a-n-a mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng left review comments

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: The SourceMapDevToolPlugin fileContext does not meet expectations
3 participants
@SyMind @ahabhgk @JSerFeng