Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add stdout draw target to multi progress #8889

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

LingyuCoder
Copy link
Contributor

Summary

fix #8690

This pull request includes updates to the ProgressPlugin in the crates/rspack_plugin_progress library to improve the progress bar functionality. The most important changes involve the initialization and usage of the MultiProgress instance and the handling of progress bars.

Improvements to progress bar functionality:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from hardfist December 30, 2024 09:42
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Dec 30, 2024
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit fac2b99
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67726aed25a119000876c6fb

@LingyuCoder LingyuCoder enabled auto-merge (squash) December 30, 2024 09:50
Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #8889 will not alter performance

Comparing fix/multi-progress-target (fac2b99) with main (92e5e4f)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@LingyuCoder LingyuCoder merged commit 99fc4cd into main Dec 30, 2024
36 checks passed
@LingyuCoder LingyuCoder deleted the fix/multi-progress-target branch December 30, 2024 10:04
@h-a-n-a h-a-n-a mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using stderr pipe w/ cross-spawn of rspack process breaks indicatif::ProgressBar (v1.0.5 --> v1.0.6)
2 participants