Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform nested webpack require with innerGraph enabled #8908

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

JSerFeng
Copy link
Contributor

Summary

fix: #8647

CompatiblePlugin parser hook relies on hookMap for_name, for_name is identifier name usually, but when the variable is tagged, for_name is the tagged name.

InnerGraph will tag all pure variables, and skip other plugins to continue handing the same identifier. InnerGraph treats var __webpack_exports__ = {} as pure declarator, it tags the variable __webpack_exports__, make CompatiblePlugin not able to transform it

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@JSerFeng JSerFeng requested a review from ahabhgk December 31, 2024 09:24
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Dec 31, 2024
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 89c3c2a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6773bf0d31b77d000859819a

ahabhgk
ahabhgk previously approved these changes Dec 31, 2024
Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #8908 will not alter performance

Comparing fix/parser-hook (89c3c2a) with main (c2d74d5)

Summary

✅ 3 untouched benchmarks

@JSerFeng JSerFeng merged commit 5cc9bae into main Dec 31, 2024
32 checks passed
@JSerFeng JSerFeng deleted the fix/parser-hook branch December 31, 2024 10:21
@h-a-n-a h-a-n-a mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error while using "externals" with "asyncWebAssemly"
3 participants