Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mark @rspack/tracing as peer dependency #9008

Merged
merged 3 commits into from
Jan 14, 2025
Merged

feat: mark @rspack/tracing as peer dependency #9008

merged 3 commits into from
Jan 14, 2025

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jan 14, 2025

Summary

Mark @rspack/tracing as peer dependency. For users using otel as their tracing layer, make sure @rspack/tracing is installed.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 14, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 094c9fb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6786162e88ef1c00088e0ca1

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9008 will not alter performance

Comparing chore-optional (094c9fb) with main (737e028)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@chenjiahan chenjiahan enabled auto-merge (squash) January 14, 2025 08:11
@chenjiahan chenjiahan merged commit ded9fc0 into main Jan 14, 2025
30 checks passed
@chenjiahan chenjiahan deleted the chore-optional branch January 14, 2025 08:17
hardfist pushed a commit that referenced this pull request Jan 14, 2025
@h-a-n-a @chenjiahan @hardfist
feat: mark @rspack/tracing as peer dependency (#9008)
5296f39 
* feat: mark `@rspack/tracing` as peer dependency

* Update packages/rspack/src/exports.ts

Co-authored-by: neverland <[email protected]>

* chore: update

---------

Co-authored-by: neverland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @chenjiahan