Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: persistent cache use multi-thread #9010

Merged
merged 2 commits into from
Jan 14, 2025
Merged

perf: persistent cache use multi-thread #9010

merged 2 commits into from
Jan 14, 2025

Conversation

jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Jan 14, 2025

Summary

persistent cache use multi-thread on serialize and deserialize.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 14, 2025
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 456ea22
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6786256c85c9e90008013ac1

Copy link
Contributor

github-actions bot commented Jan 14, 2025

📝 Benchmark detail: Open

Name Base (2025-01-14 737e028) Current Change
10000_big_production-mode_disable-minimize + exec 37.5 s ± 781 ms 38.4 s ± 404 ms +2.48 %
10000_development-mode + exec 1.85 s ± 87 ms 1.89 s ± 228 ms +2.35 %
10000_development-mode_hmr + exec 686 ms ± 22 ms 674 ms ± 4.9 ms -1.77 %
10000_production-mode + exec 2.48 s ± 210 ms 2.43 s ± 151 ms -2.14 %
10000_production-mode_persistent-cold + exec 2.59 s ± 65 ms 2.53 s ± 86 ms -2.28 %
10000_production-mode_persistent-hot + exec 2.07 s ± 191 ms 1.77 s ± 35 ms -14.55 %
arco-pro_development-mode + exec 1.8 s ± 92 ms 1.81 s ± 239 ms +0.46 %
arco-pro_development-mode_hmr + exec 388 ms ± 4.8 ms 387 ms ± 3.2 ms -0.31 %
arco-pro_production-mode + exec 3.74 s ± 178 ms 3.68 s ± 139 ms -1.59 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.75 s ± 127 ms 3.71 s ± 207 ms -1.16 %
arco-pro_production-mode_persistent-cold + exec 3.95 s ± 159 ms 3.82 s ± 291 ms -3.21 %
arco-pro_production-mode_persistent-hot + exec 2.63 s ± 176 ms 2.52 s ± 101 ms -4.43 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.78 s ± 126 ms 3.67 s ± 192 ms -3.08 %
large-dyn-imports_development-mode + exec 2.12 s ± 118 ms 2.13 s ± 99 ms +0.36 %
large-dyn-imports_production-mode + exec 2.18 s ± 65 ms 2.21 s ± 80 ms +1.46 %
threejs_development-mode_10x + exec 1.63 s ± 20 ms 1.65 s ± 111 ms +1.31 %
threejs_development-mode_10x_hmr + exec 788 ms ± 18 ms 777 ms ± 14 ms -1.42 %
threejs_production-mode_10x + exec 5.49 s ± 147 ms 5.48 s ± 194 ms -0.15 %
threejs_production-mode_10x_persistent-cold + exec 5.59 s ± 112 ms 5.59 s ± 313 ms -0.01 %
threejs_production-mode_10x_persistent-hot + exec 4.83 s ± 364 ms 4.64 s ± 164 ms -3.96 %
10000_big_production-mode_disable-minimize + rss memory 9516 MiB ± 315 MiB 9549 MiB ± 39.8 MiB +0.35 %
10000_development-mode + rss memory 656 MiB ± 12.3 MiB 679 MiB ± 25.9 MiB +3.61 %
10000_development-mode_hmr + rss memory 1386 MiB ± 275 MiB 1433 MiB ± 246 MiB +3.41 %
10000_production-mode + rss memory 663 MiB ± 45.3 MiB 676 MiB ± 31.1 MiB +1.93 %
10000_production-mode_persistent-cold + rss memory 750 MiB ± 41.6 MiB 778 MiB ± 41.3 MiB +3.74 %
10000_production-mode_persistent-hot + rss memory 740 MiB ± 30.6 MiB 796 MiB ± 61.3 MiB +7.58 %
arco-pro_development-mode + rss memory 561 MiB ± 55.2 MiB 575 MiB ± 72.8 MiB +2.47 %
arco-pro_development-mode_hmr + rss memory 601 MiB ± 85.9 MiB 610 MiB ± 56.9 MiB +1.50 %
arco-pro_production-mode + rss memory 698 MiB ± 67.6 MiB 711 MiB ± 74.4 MiB +1.79 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 742 MiB ± 57.7 MiB 722 MiB ± 82.3 MiB -2.65 %
arco-pro_production-mode_persistent-cold + rss memory 824 MiB ± 55.7 MiB 826 MiB ± 82.2 MiB +0.19 %
arco-pro_production-mode_persistent-hot + rss memory 674 MiB ± 60.6 MiB 688 MiB ± 5.94 MiB +2.02 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 743 MiB ± 116 MiB 731 MiB ± 74.9 MiB -1.65 %
large-dyn-imports_development-mode + rss memory 633 MiB ± 2.28 MiB 633 MiB ± 4.16 MiB -0.03 %
large-dyn-imports_production-mode + rss memory 528 MiB ± 3.55 MiB 526 MiB ± 3.6 MiB -0.42 %
threejs_development-mode_10x + rss memory 561 MiB ± 15.2 MiB 551 MiB ± 23.7 MiB -1.73 %
threejs_development-mode_10x_hmr + rss memory 1113 MiB ± 137 MiB 1109 MiB ± 140 MiB -0.35 %
threejs_production-mode_10x + rss memory 861 MiB ± 64.6 MiB 858 MiB ± 25.2 MiB -0.38 %
threejs_production-mode_10x_persistent-cold + rss memory 992 MiB ± 84.4 MiB 989 MiB ± 106 MiB -0.27 %
threejs_production-mode_10x_persistent-hot + rss memory 902 MiB ± 61.5 MiB 934 MiB ± 38.7 MiB +3.54 %

Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #9010 will not alter performance

Comparing jerry/cache (456ea22) with main (ded9fc0)

Summary

✅ 3 untouched benchmarks

@jerrykingxyz jerrykingxyz merged commit 995abc6 into main Jan 14, 2025
32 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/cache branch January 14, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants