Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hoist compiler options builder to Compiler::builder #9020

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jan 16, 2025

Summary

Hoisted the first level of CompilerOptions::builder to Compiler::builder to improve DX.

Updated:

let mut compiler = Compiler::builder()
    .context(Utf8Path::new(env!("CARGO_MANIFEST_DIR")).join("tests/fixtures/basic"))
    .entry("main", "./src/index.js")
    .build();

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 16, 2025
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ad0f447
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6788ce2fda4a2000086cef17

Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #9020 will not alter performance

Comparing hoist-compiler-builder (ad0f447) with main (f9aa179)

Summary

✅ 3 untouched benchmarks

@h-a-n-a h-a-n-a marked this pull request as ready for review January 16, 2025 09:21
@h-a-n-a h-a-n-a enabled auto-merge (squash) January 16, 2025 10:04
@h-a-n-a h-a-n-a merged commit cba0ccc into main Jan 16, 2025
30 checks passed
@h-a-n-a h-a-n-a deleted the hoist-compiler-builder branch January 16, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants