-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 align get provided exports with webpack #9050
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #9050 will not alter performanceComparing 🎉 Hooray!
|
related case snapshot updated;cjs‘s exports which were marked as empty within previous implementation are change to |
0c305ad
to
18b77f2
Compare
I don't think this is an appropriate fix. I'm more inclined to think that there's a mistake in webpack. According to the logic here, our original way of writing was correct. |
Ok, our original way of writing is also wrong, should be |
Summary
close #9016
the issue is caused by rspack's dll's manifest file contains an extract
exports: []
in delegated modules's description.the root of
exports: []
is that rspack always return vec in get provided exports function.solution
align the implementation with webpack
Checklist