Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 align get provided exports with webpack #9050

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

stormslowly
Copy link
Contributor

Summary

close #9016
the issue is caused by rspack's dll's manifest file contains an extract exports: [] in delegated modules's description.
the root of exports: [] is that rspack always return vec in get provided exports function.

solution

align the implementation with webpack

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 6fe73a5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/678e89539034ad0007cc1bdc
😎 Deploy Preview https://deploy-preview-9050--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hardfist
hardfist previously approved these changes Jan 20, 2025
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #9050 will not alter performance

Comparing fix/align_provide_exports (6fe73a5) with main (c06787b)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@stormslowly
Copy link
Contributor Author

related case snapshot updated;cjs‘s exports which were marked as empty within previous implementation are change to null (as determined in runtime)

hardfist
hardfist previously approved these changes Jan 20, 2025
@stormslowly stormslowly requested a review from hardfist January 20, 2025 23:50
@stormslowly stormslowly merged commit 42cc3fd into main Jan 21, 2025
30 checks passed
@stormslowly stormslowly deleted the fix/align_provide_exports branch January 21, 2025 06:25
@ahabhgk
Copy link
Contributor

ahabhgk commented Jan 22, 2025

I don't think this is an appropriate fix. I'm more inclined to think that there's a mistake in webpack. According to the logic here, our original way of writing was correct.

@ahabhgk
Copy link
Contributor

ahabhgk commented Jan 22, 2025

Ok, our original way of writing is also wrong, should be if info.redirect_to.is_none()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DLL Reference plugin results in ESModulesLinkingWarning for CJS files
3 participants