Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more keys to Web Audio #2628

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add more keys to Web Audio #2628

wants to merge 3 commits into from

Conversation

captainbrosset
Copy link
Contributor

api.AudioListener.setOrientation and api.AudioListener.setPosition are deprecated but are currently the only way to set an audio listener's orientation and position in Firefox. So there's no use creating a discouraged feature for this. At least not until https://bugzil.la/1283029 gets fixed and BCD gets updated.

For now, why don't we put these keys under Web Audio. Anyway, the whole feature uses a compute_from field which will hide any weirdness from these keys.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 10, 2025
@captainbrosset
Copy link
Contributor Author

Whoops, npm run dist isn't happy. I'm not supposed to add deprecated keys to a published feature. So, I guess we should:

  • Either ignore these keys for now.
  • Or add them to a discouraged feature, but I don't think doing this is useful to anyone.
  • Or maybe change the rules to allow adding deprecated keys somehow?

@ddbeck
Copy link
Collaborator

ddbeck commented Feb 11, 2025

OK, so now we now have a real-life example of an API that is totally harmless to use, is interoperable, but is nevertheless marked as deprecated without an interoperable alternative. Frustrating! Also, this was a specific kind of discouraged case that @atopal was concerned about.

It does seem like the sort of thing that just ought to be Baseline, at least until Firefox ships the mainstream alternative. I think my inclination here is to make some sort of exception or editorial override, assuming these cases are rare, as they have been so far.

But I'm not sure if they're rare yet. What do you think of marking this PR as a draft until we've dealt with more of the deprecated BCD keys?

@captainbrosset
Copy link
Contributor Author

Sounds good to me. Let's leave this one off to the side for now, until we find other similar cases, if any.

@captainbrosset captainbrosset marked this pull request as draft February 11, 2025 12:55
@atopal
Copy link
Collaborator

atopal commented Feb 11, 2025

Thanks for calling this out! I'd also like to see if we have more of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants