-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This test was requesting the same resource using fetch and using navigations. Navigation are request with credentials. The fetch requests weren't. This patch updates the test to make the fetch request to send credentials. This ensures passing this test is not simply the consequence of discriminating anonymous and credentialled request in the HTTP cache, but really about implementing a split cache. This ensures implementing: https://docs.google.com/document/d/1lvbiy4n-GM5I56Ncw304sgvY5Td32R6KHitjRXvkZ6U/edit#heading=h.i5fo7881c05m won't cause one test case of this test to pass when split cache is disabled. https://chromium-review.googlesource.com/c/chromium/src/+/2964120/7/third_party/blink/web_tests/virtual/not-split-http-cache/external/wpt/fetch/http-cache/split-cache-expected.txt Bug:1221529 Change-Id: I3e7fdfa1a21570b5128f87238238aea4a92a8a0f
- Loading branch information
1 parent
a97a1e3
commit b245c2f
Showing
3 changed files
with
26 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters