[fetch] Test that User-Agent is not a forbidden request header
#39301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`User-Agent` used to be a forbidden request header until it was removed in whatwg/fetch#37. However, this was never added as a WPT test, and Chrome still treats it as forbidden. This change adds that test.
annevk
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
There is at least https://wpt.fyi/results/xhr/preserve-ua-header-on-redirect.htm?label=experimental&label=master&aligned but it seems reasonable to have another test.
andreubotella
deleted the
andreubotella/user-agent-not-a-forbidden-request-header
branch
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
…-platform-tests#39301) `User-Agent` used to be a forbidden request header until it was removed in whatwg/fetch#37. However, this was never added as a WPT test, and Chrome still treats it as forbidden. This change adds that test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Agentused to be a forbidden request header until it was removed in whatwg/fetch#37. However, this removal was never tested in WPT, and Chrome still treats it as forbidden. This change adds that test.