url: Stop passing DOMException.prototype to URLSearchParams's constructor. #6552

rakuco · 2017-07-14T10:24:16Z

new URLSearchParams(DOMException.prototype)
DOMException.prototype.toString()

are supposed to throw an exception due to brand checks in properties such as
"name" and "message", which meant compliant implementations were always
failing one of the tests here.

Fix it by passing a DOMException instead: it has all the constants we need
and passes the required property checks. Also assert that the previous
behavior throws a TypeError.

annevk · 2017-07-14T10:38:53Z

Safari TP does pass this test. Is that https://bugs.webkit.org/show_bug.cgi?id=174216 then? @youennf thoughts?

ghost · 2017-07-14T10:40:41Z

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 7cfea82
Using browser at version BuildID 20170713100259; SourceStamp 30ea2905130e85f9e1d8d56fa3097901eec6514b
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/urlsearchparams-constructor.html

Subtest	Results	Messages
	OK
`Basic URLSearchParams construction`	PASS
`URLSearchParams constructor, no arguments`	PASS
`URLSearchParams constructor, DOMException as argument`	PASS
`URLSearchParams constructor, empty string as argument`	PASS
`URLSearchParams constructor, {} as argument`	PASS
`URLSearchParams constructor, string.`	PASS
`URLSearchParams constructor, object.`	PASS
`Parse +`	PASS
`Parse encoded +`	PASS
`Parse space`	PASS
`Parse %20`	PASS
`Parse \0`	PASS
`Parse %00`	PASS
`Parse â��`	PASS
`Parse %e2%8e%84`	PASS
`Parse ð��©`	PASS
`Parse %f0%9f%92%a9`	PASS
`Constructor with sequence of sequences of strings`	PASS
`Construct with object with +`	PASS
`Construct with object with two keys`	PASS
`Construct with array with two keys`	PASS
`Construct with object with NULL, non-ASCII, and surrogate keys`	PASS
`Custom [Symbol.iterator]`	PASS

ghost · 2017-07-14T10:40:41Z

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 7cfea82
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/urlsearchparams-constructor.html

Subtest	Results	Messages
	OK
`Basic URLSearchParams construction`	FAIL	`Can't find variable: URLSearchParams`
`URLSearchParams constructor, no arguments`	FAIL	`Can't find variable: URLSearchParams`
`URLSearchParams constructor, DOMException as argument`	FAIL	`Can't find variable: URLSearchParams`
`URLSearchParams constructor, empty string as argument`	FAIL	`Can't find variable: URLSearchParams`
`URLSearchParams constructor, {} as argument`	FAIL	`Can't find variable: URLSearchParams`
`URLSearchParams constructor, string.`	FAIL	`Can't find variable: URLSearchParams`
`URLSearchParams constructor, object.`	FAIL	`Can't find variable: URLSearchParams`
`Parse +`	FAIL	`Can't find variable: URLSearchParams`
`Parse encoded +`	FAIL	`Can't find variable: URLSearchParams`
`Parse space`	FAIL	`Can't find variable: URLSearchParams`
`Parse %20`	FAIL	`Can't find variable: URLSearchParams`
`Parse \0`	FAIL	`Can't find variable: URLSearchParams`
`Parse %00`	FAIL	`Can't find variable: URLSearchParams`
`Parse â��`	FAIL	`Can't find variable: URLSearchParams`
`Parse %e2%8e%84`	FAIL	`Can't find variable: URLSearchParams`
`Parse ð��©`	FAIL	`Can't find variable: URLSearchParams`
`Parse %f0%9f%92%a9`	FAIL	`Can't find variable: URLSearchParams`
`Constructor with sequence of sequences of strings`	FAIL	`Can't find variable: URLSearchParams`
`Construct with object with +`	FAIL	`Can't find variable: URLSearchParams`
`Construct with object with two keys`	FAIL	`Can't find variable: URLSearchParams`
`Construct with array with two keys`	FAIL	`Can't find variable: URLSearchParams`
`Construct with object with NULL, non-ASCII, and surrogate keys`	FAIL	`Can't find variable: URLSearchParams`
`Custom [Symbol.iterator]`	FAIL	`Can't find variable: URLSearchParams`

ghost · 2017-07-14T10:40:42Z

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 7cfea82
Using browser at version 61.0.3153.4 dev
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/urlsearchparams-constructor.html

Subtest	Results	Messages
	OK
`Basic URLSearchParams construction`	PASS
`URLSearchParams constructor, no arguments`	PASS
`URLSearchParams constructor, DOMException as argument`	PASS
`URLSearchParams constructor, empty string as argument`	PASS
`URLSearchParams constructor, {} as argument`	PASS
`URLSearchParams constructor, string.`	PASS
`URLSearchParams constructor, object.`	PASS
`Parse +`	PASS
`Parse encoded +`	PASS
`Parse space`	PASS
`Parse %20`	PASS
`Parse \0`	PASS
`Parse %00`	PASS
`Parse ⎄`	PASS
`Parse %e2%8e%84`	PASS
`Parse 💩`	PASS
`Parse %f0%9f%92%a9`	PASS
`Constructor with sequence of sequences of strings`	PASS
`Construct with object with +`	PASS
`Construct with object with two keys`	PASS
`Construct with array with two keys`	PASS
`Construct with object with NULL, non-ASCII, and surrogate keys`	PASS
`Custom [Symbol.iterator]`	PASS

ghost · 2017-07-14T10:40:42Z

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 7cfea82
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/urlsearchparams-constructor.html

Subtest	Results	Messages
	OK
`Basic URLSearchParams construction`	FAIL	`'URLSearchParams' is undefined`
`URLSearchParams constructor, no arguments`	FAIL	`'URLSearchParams' is undefined`
`URLSearchParams constructor, DOMException as argument`	FAIL	`'URLSearchParams' is undefined`
`URLSearchParams constructor, empty string as argument`	FAIL	`'URLSearchParams' is undefined`
`URLSearchParams constructor, {} as argument`	FAIL	`'URLSearchParams' is undefined`
`URLSearchParams constructor, string.`	FAIL	`'URLSearchParams' is undefined`
`URLSearchParams constructor, object.`	FAIL	`'URLSearchParams' is undefined`
`Parse +`	FAIL	`'URLSearchParams' is undefined`
`Parse encoded +`	FAIL	`'URLSearchParams' is undefined`
`Parse space`	FAIL	`'URLSearchParams' is undefined`
`Parse %20`	FAIL	`'URLSearchParams' is undefined`
`Parse \0`	FAIL	`'URLSearchParams' is undefined`
`Parse %00`	FAIL	`'URLSearchParams' is undefined`
`Parse ⎄`	FAIL	`'URLSearchParams' is undefined`
`Parse %e2%8e%84`	FAIL	`'URLSearchParams' is undefined`
`Parse 💩`	FAIL	`'URLSearchParams' is undefined`
`Parse %f0%9f%92%a9`	FAIL	`'URLSearchParams' is undefined`
`Constructor with sequence of sequences of strings`	FAIL	`'URLSearchParams' is undefined`
`Construct with object with +`	FAIL	`'URLSearchParams' is undefined`
`Construct with object with two keys`	FAIL	`'URLSearchParams' is undefined`
`Construct with array with two keys`	FAIL	`'URLSearchParams' is undefined`
`Construct with object with NULL, non-ASCII, and surrogate keys`	FAIL	`'URLSearchParams' is undefined`
`Custom [Symbol.iterator]`	FAIL	`'URLSearchParams' is undefined`

rakuco · 2017-07-14T10:40:59Z

Safari TP does pass this test. Is that https://bugs.webkit.org/show_bug.cgi?id=174216 then?

I think so, Domenic filed that one after the spec change was merged.

annevk · 2017-07-14T10:42:27Z

Maybe also add another test that ensures DOMException.prototype throws the correct exception.

rakuco · 2017-07-14T10:43:55Z

Isn't that already covered by #6361?

annevk · 2017-07-14T11:01:41Z

Generally yes, but not the specific binding for this feature. It's always a little bit unclear to me how much we should test the binding on a per-feature basis, but some spot testing doesn't hurt I think.

rakuco · 2017-07-14T11:04:04Z

OK, so you mean specifically testing that new URLSearchParams(DOMException.prototype) throws a TypeError? I can do that, though personally I don't see anything specific to this, i.e. it doesn't seem different than asserting that record<K,V> conversions with prototype objects with attributes throw anywhere else.

annevk · 2017-07-14T11:21:38Z

Yeah, that's what I meant. I think it's in the same realm as testing that DOMException itself stringifies here (and how). Maybe we shouldn't test either though, but I think it does help catch bugs if the bindings end up being implemented differently at some point.

…ctor. As of whatwg/webidl#378, both new URLSearchParams(DOMException.prototype) DOMException.prototype.toString() are supposed to throw an exception due to brand checks in properties such as "name" and "message", which meant compliant implementations were always failing one of the tests here. Fix it by passing a `DOMException` instead: it has all the constants we need and passes the required property checks. Also assert that the previous behavior throws a TypeError.

rakuco · 2017-07-14T11:31:17Z

I've added an assert_throws there to cover DOMException.prototype, please take another look.

wpt-pr-bot added the url label Jul 14, 2017

wpt-pr-bot requested review from annevk, domenic, GPHemsley, mikewest, rubys, Sebmaster, smola, tomalec, xiaojunwu and zcorpan July 14, 2017 10:24

annevk approved these changes Jul 14, 2017

View reviewed changes

annevk merged commit 125950d into web-platform-tests:master Jul 14, 2017

rakuco deleted the urlsearchparams-constructor-domexception branch July 14, 2017 13:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

url: Stop passing DOMException.prototype to URLSearchParams's constructor. #6552

url: Stop passing DOMException.prototype to URLSearchParams's constructor. #6552

rakuco commented Jul 14, 2017 •

edited by wpt-pr-bot

Loading

annevk commented Jul 14, 2017

ghost commented Jul 14, 2017 •

edited by ghost

Loading

ghost commented Jul 14, 2017 •

edited by ghost

Loading

ghost commented Jul 14, 2017 •

edited by ghost

Loading

ghost commented Jul 14, 2017 •

edited by ghost

Loading

rakuco commented Jul 14, 2017

annevk commented Jul 14, 2017

rakuco commented Jul 14, 2017

annevk commented Jul 14, 2017

rakuco commented Jul 14, 2017

annevk commented Jul 14, 2017

rakuco commented Jul 14, 2017

url: Stop passing DOMException.prototype to URLSearchParams's constructor. #6552

url: Stop passing DOMException.prototype to URLSearchParams's constructor. #6552

Conversation

rakuco commented Jul 14, 2017 • edited by wpt-pr-bot Loading

annevk commented Jul 14, 2017

ghost commented Jul 14, 2017 • edited by ghost Loading

Firefox (nightly)

All results

ghost commented Jul 14, 2017 • edited by ghost Loading

Sauce (safari)

All results

ghost commented Jul 14, 2017 • edited by ghost Loading

Chrome (unstable)

All results

ghost commented Jul 14, 2017 • edited by ghost Loading

Sauce (MicrosoftEdge)

All results

rakuco commented Jul 14, 2017

annevk commented Jul 14, 2017

rakuco commented Jul 14, 2017

annevk commented Jul 14, 2017

rakuco commented Jul 14, 2017

annevk commented Jul 14, 2017

rakuco commented Jul 14, 2017

rakuco commented Jul 14, 2017 •

edited by wpt-pr-bot

Loading

ghost commented Jul 14, 2017 •

edited by ghost

Loading

ghost commented Jul 14, 2017 •

edited by ghost

Loading

ghost commented Jul 14, 2017 •

edited by ghost

Loading

ghost commented Jul 14, 2017 •

edited by ghost

Loading