Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS headers on errors to make debugging less painful #73

Closed
olizilla opened this issue Jul 13, 2021 · 1 comment · Fixed by #85
Closed

Add CORS headers on errors to make debugging less painful #73

olizilla opened this issue Jul 13, 2021 · 1 comment · Fixed by #85
Assignees
@olizilla

Comments

@olizilla
Copy link
Contributor

it's hard to know what the error is, when it's masked by a "CORS headers missing" error
@olizilla olizilla self-assigned this Jul 14, 2021
@olizilla
Copy link
Contributor Author

I'm tackling this as part of the work on #78

olizilla added a commit that referenced this issue Jul 14, 2021
@olizilla
fix: set cors headers on errors
b01459a 
Making debugging failures less awkward.

fixes #73

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla mentioned this issue Jul 14, 2021
Merged
alanshaw pushed a commit that referenced this issue Jul 15, 2021
@olizilla
fix: set cors headers on errors (#85)
b034fc5 
Making debugging failures less awkward.

fixes #73

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olizilla olizilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set cors headers on errors web3-storage/web3.storage
1 participant
@olizilla