-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cron pin update for [email protected] #1228
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IPFS Cluster v1 release has much improved perf, and some breaking API changes. In this PR we upgrade the ipfs-cluster client and local test environment to work with the v1 cluster API. When this PR is merged to main, the staging API credentials must be updated. The production release of this PR needs to be coordinated with the upgrade of the ipfs-cluster binaries on the prod cluster. There will be a second PR to update the pins cron, which should be merged to main once the prod cluster is upgraded. see: #1184 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
Adopt the new ipfs-cluster client to be ready for the ipfs cluster v1 roll out. Should be merged to main **after** the production cluster is upgraded to v1 see: #1184 see: #1227 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
This was referenced Apr 7, 2022
vasco-santos
requested changes
Apr 8, 2022
@@ -47,7 +47,7 @@ services: | |||
|
|||
cluster0: | |||
container_name: cluster0 | |||
image: ipfs/ipfs-cluster:v0.14.5 | |||
image: ipfs/ipfs-cluster:v1.0.0-rc3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
image: ipfs/ipfs-cluster:v1.0.0-rc3 | |
image: ipfs/ipfs-cluster:v1.0.0-rc4 |
will have conflict once #1227 merged
@@ -16,7 +16,7 @@ | |||
"author": "Alan Shaw", | |||
"license": "(Apache-2.0 OR MIT)", | |||
"dependencies": { | |||
"@nftstorage/ipfs-cluster": "^4.0.0", | |||
"@nftstorage/ipfs-cluster": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"@nftstorage/ipfs-cluster": "^5.0.0", | |
"@nftstorage/ipfs-cluster": "^5.0.1", |
olizilla
added a commit
that referenced
this pull request
Apr 8, 2022
The IPFS Cluster v1 release has much improved perf, and some breaking API changes. In this PR we upgrade the ipfs-cluster client and local test environment to work with the v1 cluster API. ### Testing it - Our integration tests have been updated to use the v1 cluster and now pass with this changeset. - This PR is also tested locally by pointing a dev api at the `nft.storage.ipfscluster.io` cluster which is now used for QA and is running [email protected] - The staging deployment should be tested when this PR is merged to main. ### Deploying it The **staging API cluster credentials must be updated** on Cloudflare after this PR is merged to main. To deploy to production we need to: - Put the API into READ-ONLY (check, do we read from cluster in read-only? if so do we hit any api that has changed? - Deploy [email protected] to the production web3 cluster - Merge the API release PR and wait for the API deployment to complete. - Merge the #1228 PR, to update the affected cron jobs - Put the API back into RW mode and monitor. - FIN see: #1184 see: https://github.com/nftstorage/ipfs-cluster/releases/tag/v5.0.0 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
superseeded by #1234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the new ipfs-cluster client to be ready for the ipfs cluster v1 roll out.
Should be merged to main after the production cluster is upgraded to v1
see: #1184
see: #1227
License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans [email protected]